[Dcmlib] RTSTRUCT and RTPlanStorage

[Vincent Daanen]

Hi Math,

sorry if I hurt you with my humour 'pince sans rince'

Mathieu Malaterre a écrit :
> Vincent Daanen wrote:
>> hi
>>
>> Mathieu, "ne ferais-tu pas un peu de mauvais esprit la ?" ;-)
>
> To be truely honest, I am kind of pushing people out gdcm1.x toward 
> gdcm2. But that's another discussion.
>
>> The code below just allows to get all the numerical values from a DS 
>> into a std::vector, regarding of the (group, element). I'm not a guru 
>> of the dicom file format but I guess DS is
>> often use and so, a small method which allows to get the n values of 
>> a DS ( n from 3 to ... 200-300 ?) would be, imho, very useful.
>
> Alright then. Now let's do some generic programming. Instead of doing 
> on a per DICOM tags, you are asking on a per type basis.
>
> So we need a function per types, right ? Here are the tags:
[cut]

> So again, if there is something missing, it's in gdcmDataEntry. Maybe 
> an operator to std::vector, but types will be a nightmare. I still 
> really like the current design where the operations should only be 
> read (from file), write (to file), print (cout/cerr). Anything else is 
> application oriented and not library oriented IMHO.
>
you may be right but of all this type basis, how much may be something 
like a DS ? According to me basis type related to single type (int8 | 
int16 | int 32, uint8 | uint16 | uint 32, char, float, ...) does not 
require such as method !
But I may be wrong because, again, I do know Dicom in depth.

>> I'm quite sure that in applications that handle dicom files (not only 
>> dicom images), there is a method that parses DS into std::vector so 
>> why do not add it in gdcm ?
>
> application, you said the word !
>
>> ... and ... you will be be able to read, let's say, ~ 1000 others 
>> tags :-P
>
> $ grep DS dicomV3.dic | grep -v "DS 1 " | wc
>                  71     504    2817
>
> 71 tags, only  :(
OK, I was a beat optimistic :-(
>
> Again I might be "mauvais esprit", but I would rather see the code 
> well integrated with generic type into gdcm::DataEntry, rather than 
> just copy/pasting for an extremely specific app.
>
I do not know sufficiently gdcm to propose another solution; I'm just an 
user !

Vincent

-- 
Vincent Daanen, PhD
Research Engineer, Post-Doctoral Position
Laboratoire TIMC/IMAG (Univ. Joseph Fourier - CNRS UMR 5525)
Equipe GMCAO
Institut d'Ingénierie de l'Information de Santé (IN3S)
Faculté de Médecine - 38706 La Tronche cedex - France
Tel: +33 (0)4 56 52 00 54 - Fax: +33 (0)4 56 52 00 55
Vincent.Daanen at imag.fr

"Les problèmes ne peuvent être résolus par
ceux dont l'horizon se limite aux réalités 
quotidiennes, mais par ceux qui rêvent de 
choses qui n'ont jamais existées et qui se 
disent : Pourquoi Pas ?"

J-F Kennedy, 1963.