[Dcmlib] Re: [Gdcm2] gdcmPrinter

Jean-Pierre Roux Jean-Pierre.Roux at creatis.insa-lyon.fr
Wed Mar 8 16:26:09 CET 2006 

Mathieu Malaterre wrote:

>Salut,
>
>   Ok j'ai un peu avancer dans la structure du gdcmPrinter. Si vous avez deux minutes merci de l'essayer. J'ai essayer de garder en tete une consommation memoire mimimun:
>- Je retuilise tout le temps le meme gdcm::DataElement, 
>- avec un taille max de 0xfff (meme astuce que gdcm1.x)
>
>Ca fais que j'ai sur tout gdcmData:
>$ time ./bin/gdcmTests TestPrinter >& /tmp/log
>./bin/gdcmTests TestPrinter >&/tmp/log  0.34s user 0.27s system 99% cpu 0.618 total
>
>  
>
Sur mon PC, avec mes données

gdcm2 :
time ./bin/gdcmTests TestPrinter >& /tmp/log
real    0m1.532s
user    0m0.836s
sys     0m0.624s

gdcm  (CVS version):
time gdcmTests TestPrintAllDocument >& /tmp/log
real    0m4.385s
user    0m3.000s
sys     0m1.332s

En elapsed time, il y a un facteur 3 en faveur de gdcm2.
Mais gdcm2 n'explore pas recursivement les sequences.
Pour faire des comparaisons, toutes choses egales d'ailleurs, il 
faudrait pouvoir demander a gdcm2 d'explorer aussi les sequences (meme 
si ca ne sert a rien dans les cas 'habituels')

D'autre part, il y a qq chose qui continue a m'ennuyer bcp, c'est que 
gdcm2 pete sur de nombreux tests :
[jpr at localhost gdcmbin]$ ctest
Test project
  1/ 28 Testing TestAllLoadMinimumStuff       ***Exception: Other
  2/ 28 Testing TestTag                          Passed
  3/ 28 Testing TestFileIO                       Passed
  4/ 28 Testing TestFileChunk                    Passed
  5/ 28 Testing TestTagIO                        Passed
  6/ 28 Testing TestDataElement                  Passed
  7/ 28 Testing TestVRValueLength                Passed
  8/ 28 Testing TestVR                           Passed
  9/ 28 Testing TestSwap                         Passed
 10/ 28 Testing TestGroup                        Passed
 11/ 28 Testing TestVM                           Passed
 12/ 28 Testing TestTS                           Passed
 13/ 28 Testing TestDictEntry                    Passed
 14/ 28 Testing TestDict                         Passed
 15/ 28 Testing TestDataSet                      Passed
 16/ 28 Testing TestSequenceOfItems              Passed
 17/ 28 Testing TestAllPrint                     Passed
 18/ 28 Testing TestGroupDict                    Passed
 19/ 28 Testing TestPrintGroup                ***Exception: Other
 20/ 28 Testing TestGroupSet                     Passed
 21/ 28 Testing TestItem                         Passed
 22/ 28 Testing TestFileSeeker                ***Exception: Other
 23/ 28 Testing TestDirectory                    Passed
 24/ 28 Testing TestAllPrintUID               ***Exception: Other
 25/ 28 Testing TestLoader                    ***Failed
 26/ 28 Testing TestPrinter                      Passed
 27/ 28 Testing TestTableReader                  Passed
 28/ 28 Testing TestAttributeFactory          ***Exception: SegFault

79% tests passed, 6 tests failed out of 28

TestPrintGroup pete sur:  
/home/jpr/DataLinuxWindoze/gdcmData/CT-MONO2-12-lomb-an2.acr
 /home/jpr/gdcm2/gdcm/Source/Common/gdcmIStream.h:24: 
gdcm::IStream::~IStream(): Assertion `!(InternalStream.is_open())' failed.

TestFileSeeker   pete sur : 
/home/jpr/DataLinuxWindoze/gdcmData/012345.002.050.dcm
gdcmTests: /home/jpr/gdcm2/gdcm/Source/Common/gdcmIStream.cxx:11: 
gdcm::IStream& gdcm::IStream::Read(char*, std::streamsize): Assertion 
`!(!InternalStream)' failed.

TestAllPrintUID            
pete sur : /home/jpr/DataLinuxWindoze/gdcmData/012345.002.050.dcm
gdcmTests: /home/jpr/gdcm2/gdcm/Source/Common/gdcmIStream.cxx:11: 
gdcm::IStream& gdcm::IStream::Read(char*, std::streamsize): Assertion 
`!(!InternalStream)' failed.

TestAttributeFactory
pete avec segfault :
 28/ 28 Testing TestAttributeFactory
Test command: /home/jpr/gdcm2/gdcmbin/bin/gdcmObjectsTests 
TestAttributeFactory
2.52.5
2.5,3.52.5\3.5
2.5,3.5,4.52.5\3.5\4.5
2.5,3.5,4.5,02.5\3.5\4.5\0
2.5,3.5,4.5,5.5,6.52.5\3.5\4.5\5.5\6.5
2.5,3.5,4.5,5.5,6.5,7.52.5\3.5\4.5\5.5\6.5\7.5
2.5,3.5,4.5,5.5,6.5,7.5,0,02.5\3.5\4.5\5.5\6.5\7.5\0\0
2.5,3.5,4.5,5.5,6.5,7.5,0,0,0,0,0,0,0,0,0,02.5\3.5\4.5\5.5\6.5\7.5\0\0\0\0\0\0\0\0\0\0
2.5,3.5,4.5,5.5,6.5,7.5,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,02.5\3.5\4.5\5.5\6.5\7.5\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0
2.5,3.5,4.5,5.5,6.5,7.5,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,02.5\3.5\4.5\5.5\6.5\7.5\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0
1.1,2.2,3.3,4.4,5.5,6.61.1\2.2\3.3\4.4\5.5\6.6
1,2,3,4,5,6,7,8,9,10,11,12,131\2\3\4\5\6\7\8\9\10\11\12\13
2.00816e+17,2.03067e+17,2.05319e+172.00816e+17\2.03067e+17\2.05319e+17

*** Exception executing: Segmentation fault
***Exception: SegFault

(il n'a pas le temps d'entrer dans TestFloatN)


Et TestAllLoadMinimumStuff pete sur  
/home/jpr/DataLinuxWindoze/gdcmData/012345.002.050.dcm
gdcmTests: /home/jpr/gdcm2/gdcm/Source/Common/gdcmIStream.cxx:11: 
gdcm::IStream& gdcm::IStream::Read(char*, std::streamsize): Assertion `!


Ce fichier a vraiment l'air de poser des pb ...
Il ne contient pourtant aucune SequenceOfItems, est en TS =[JPEG 
Lossless, Non-Hierarchical, First-Order Prediction (Process 14 
[Selection Value 1])] bien propre
s'affiche (entete et pixels) sans probleme avec gdcm ...

==> Mathieu, tu me disais que tout passait normalement, sur ton PC, 
c'est ca (?!?)
==> Benoit, si tu as 10mn, pourrais-tu faire un ctest de gdcm2 sur ton 
PC Linux, et me dire ce qu'il est en?.
Thx
JPRx


-> D'autre part, avec MSVC7, ca pete a la compile a peu pres partout :-(



-- Proc

>Mathieu
>
>
>
>-------------------------------------------------------
>This SF.Net email is sponsored by xPML, a groundbreaking scripting language
>that extends applications into web and mobile media. Attend the live webcast
>and join the prime developer group breaking into this new coding territory!
>http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
>_______________________________________________
>Gdcm-developers mailing list
>Gdcm-developers at lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/gdcm-developers
>
>  
>



-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Gdcm-developers mailing list
Gdcm-developers at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gdcm-developers

More information about the Dcmlib mailing list