[Dcmlib] Re: gdcm with BCB6

[Mathieu Malaterre]

Luca,

	Just to be sure, could you take a fresh cvs update (no local 
modification) and double check that everything is fine now ?

Thanks again for your time
Mathieu

Luca Picello wrote:
> 
> Wow, finally it works !!
> commenting the 2 lines below and adding to gdcmValEntry.cxx
> #include <ctype.h>  // for isdigit
> #include <stdlib.h> // for atoi
> 
> Thank you very much!!! Now I can sync with CVS as normal users do :-)
> Ciao,
> 
> Luca
> 
> 
> Mathieu Malaterre wrote:
> 
>>
>> Luca,
>>
>>     The GetTickCount is really nasty. I haven't found a real solution. 
>> Could you please try to update gdcm and try to compile. Could you try 
>> to comment the two following lines like this:
>>
>> ..
>> //#ifndef __BORLANDC__
>>   #undef GetCurrentTime
>> //#endif
>> ..
>>
>> Thanks
>> Mathieu
>>
>> Luca Picello wrote:
>>
>>> Hello, I modified
>>>
>>> gdcmException.cxx adding
>>> #include <stdlib.h> // for exit
>>>
>>> gdcmFile.cxx  with
>>> #include <stdlib.h> // for atoi
>>>
>>> gdcmTS.cxx with
>>> #include <ctype.h> // for isdigit
>>>
>>> however in gdcmUtil.cxx the GetTickCount() is missing.
>>> I do not know why, it should be defined in winbase.h ...
>>>
>>> Thanks a million,
>>>
>>> Luca
>>>
>>>
>>>
>>>
>>> Mathieu Malaterre wrote:
>>>
>>>> Luca,
>>>>
>>>>     Can you try again ?
>>>>
>>>> Thanks
>>>> Mathieu
>>>>
>>>> Luca Picello wrote:
>>>>
>>>>> ok. here you can see functions that are missing.
>>>>>
>>>>> isdigit() is defined in ctype.h
>>>>> atoi() is defined in stdlib.h
>>>>>
>>>>> Do not mind about "Assertion failed Z:\gdcm.cvs\etc..:" : it is a 
>>>>> known compiler bug. It disappears when previous error messages are 
>>>>> solved.
>>>>>
>>>>> ciao,
>>>>> Luca
>>>>>
>>>>>
>>>>>
>>>>> Mathieu Malaterre wrote:
>>>>>
>>>>>> Luca,
>>>>>>
>>>>>>     Thanks for your help, you just found a bug in gdcm. I believe 
>>>>>> this is fixed now (stdint.h was always skipped on Win32 system).
>>>>>>
>>>>>> Could you please try again, thanks
>>>>>> Mathieu
>>>>>>
>>>>>> Luca Picello wrote:
>>>>>>
>>>>>>> Here the result without "wrong" include files.
>>>>>>> Have a good weekend,
>>>>>>>
>>>>>>> Luca
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> .
>>>>>>
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------ 
>>>>>
>>>>>
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> cmake.depends is up-to-date
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> Z:/gdcm.bin.cvs/Dicts: building default_target
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> cmake.depends is up-to-date
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> Z:/gdcm.bin.cvs/src: building default_target
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>>>> Building object file gdcmDocument.obj...
>>>>> Borland C++ 5.6.4 for Win32 Copyright (c) 1993, 2002 Borland
>>>>> Z:\gdcm.cvs\src\gdcmDocument.cxx:
>>>>> Error E2268 Z:\gdcm.cvs\src\gdcmDocument.cxx 379: Call to undefined 
>>>>> function 'isdigit' in function Document::GetTransferSyntax()
>>>>> Error E2268 Z:\gdcm.cvs\src\gdcmDocument.cxx 962: Call to undefined 
>>>>> function 'atoi' in function Document::ParseDES(DocEntrySet 
>>>>> *,long,long,bool)
>>>>> Error E2268 Z:\gdcm.cvs\src\gdcmDocument.cxx 1609: Call to 
>>>>> undefined function 'atoi' in function 
>>>>> Document::GetDocEntryUnvalue(DocEntry *)
>>>>> Error E2268 Z:\gdcm.cvs\src\gdcmDocument.cxx 1623: Call to 
>>>>> undefined function 'atoi' in function 
>>>>> Document::GetDocEntryUnvalue(DocEntry *)
>>>>> Assertion failed Z:\gdcm.cvs\src\gdcmDocument.cxx(2061) : 
>>>>> CurrentDtorContext->dcOuterCtxOfs == CurrentExcContextOfs at 
>>>>> d:\helena\bcc\indep\stmt.c(9779)
>>>>>
>>>>> ** error 3 ** deleting gdcmDocument.obj
>>>>>
>>>>> ** error 1 ** deleting default_target
>>>>>
>>>>> ** error 1 ** deleting default_target_src
>>>>>
>>>>> ** error 1 ** deleting default_target
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> .
>>>>
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> cmake.depends is up-to-date
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> Z:/gdcm.bin.cvs/Dicts: building default_target
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> cmake.depends is up-to-date
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> Z:/gdcm.bin.cvs/src: building default_target
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> MAKE Version 5.2  Copyright (c) 1987, 2000 Borland
>>> Building object file gdcmUtil.obj...
>>> Borland C++ 5.6.4 for Win32 Copyright (c) 1993, 2002 Borland
>>> Z:\gdcm.cvs\src\gdcmUtil.cxx:
>>> Error E2316 Z:\gdcm.cvs\src\gdcmUtil.cxx 289: 'Util::GetTickCount()' 
>>> is not a member of 'Util'
>>> *** 1 errors in Compile ***
>>>
>>> ** error 1 ** deleting gdcmUtil.obj
>>>
>>> ** error 1 ** deleting default_target
>>>
>>> ** error 1 ** deleting default_target_src
>>>
>>> ** error 1 ** deleting default_target
>>
>>
>>
>> .
>>
> 
>